Additional check if values have changed in bindToEntry #6528

calixtus · 2020-05-26T16:32:50Z

Change in CHANGELOG.md described (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

calixtus · 2020-05-27T20:59:15Z

Not yet mergeable, it's still in testing. I'm not sure if this really solved the problem. I'm waiting for @gianlucabaldassarre to answer in the issue thread.

Siedlerchr · 2020-05-28T06:54:39Z

Seesms not to work.
Type randomly in the comment field and create new lines etc and type again
hit ctrl + s cursor jumps again to the beginning

gianlucabaldassarre · 2020-05-28T11:35:11Z

@Siedlerchr : OK, so I wait for updated versions.

…

Seesms not to work. Type randomly in the comment field and create new lines etc and type again hit ctrl + s cursor jumps again to the beginning

calixtus · 2020-05-28T11:41:58Z

@Siedlerchr just put me on a track. The issue occurs now, if you save after creating a new line... In saving, the fields are trimmed of whitespaces...

calixtus · 2020-05-28T11:49:53Z

This should do the trick. Let's wait for the deployment.

tobiasdiez · 2020-05-28T12:04:35Z

Mhhh, this looks dangerous. Not sure what consequences could arise when the field value and textfield value are different (even if it just whitespace difference). What about moving the trim from saving to the set field value method in BibEntry? Ok, maybe this also doesn't work since then users cannot type anything with spaces at the end because they are immediately deleted... damn.

Another idea: preserve the caret position by hand as in https://stackoverflow.com/a/45334996/873661 (if they really differ only by trimmed whitespace, the new caret position should be easy to calculate)

Siedlerchr · 2020-05-28T12:10:00Z

Tested it from eclipse, does not change anything, caret still jumps to the beginning

gianlucabaldassarre · 2020-05-28T12:54:27Z

System:
JabRef 5.1-PullRequest6528.455--2020-05-26--0965648
Windows 10 10.0 amd64
Java 14.0.1

...If it can help with the problem (sorry if this is naive!):
By directly typing into the multi-line tab "{} biblatex source" (with 1 field) the problem of jumping is not there. Maybe you could use the same code used there for the fields showing the problem?

Moreover, I just discovered that typing into the multi-line fields as "Abstract" and "Comment" (those with the problem) you have you have a lag for which if you type fast you cannot see what you are typing: a problem you do not have when directly typing within "{} biblatex source" where typing is a much smoother (normal) experience.

calixtus · 2020-05-28T13:21:34Z

Next round of testing: https://builds.jabref.org/pull/6528/merge/ 😁
Thank you all for your patience. This bug seems to be somewhat tricky to catch.

calixtus · 2020-05-28T13:28:43Z

Expected behaviour should be now after 8bcc65b:
While editing the contents of the editor field should always remain the same, including whitespaces etc. After changing the entry and saving, the contents are trimmed.

@gianlucabaldassarre Thanks for the note. The source editor is using a different kind of entry editor, called richtextfx (or to be exact CodeArea). This editor has higher demands on memory and processor time. So we try to use this only when necessary.

Siedlerchr · 2020-05-28T14:10:09Z

Hm. I tested your latest changes on this branch, for me it's still happening

calixtus · 2020-05-28T14:27:15Z

I really don't get it. It worked for me, maybe you something I don't see yet.
Can you please describe step by step what you are doing?

Siedlerchr · 2020-05-28T15:49:36Z

I recorded a gif

I started JabRef from eclipse with addtional command line parameter --debug

tobiasdiez · 2020-05-28T16:12:04Z

@Siedlerchr can you set a breakpoint in the binding code, and see if it's called (and if yes with which values of before/after)

Siedlerchr · 2020-05-28T16:20:55Z

Okay, debugging reveals:
The binding code triggers for every entered char.
It seems there is some issue with line breaks
I just typed a and a newline and another a in the next line

newValue: a\na\n
oldValue: a\r\na

tobiasdiez · 2020-05-28T16:32:33Z

Ahhh...the textarea always uses \n for line breaks (it's hard-coded: https://github.com/openjdk/jfx/blob/master/modules/javafx.controls/src/main/java/javafx/scene/control/TextArea.java#L129) but JabRef uses OS.NEWLINE upon save.

calixtus · 2020-05-28T18:06:30Z

Oh no... That raises more problems.
So the basic solution should actually be right, now it's about how the TextArea is compared to the newValue. Should be enough to replace in the string every OS.NEWLINE with \n...

tobiasdiez · 2020-05-28T18:36:20Z

Thinking about it, it might also be the reason for some of the "Library has been modified by another application." issues. #4877 Maybe we should rethink the newline handling on save...

calixtus · 2020-05-28T18:44:11Z

Should we always save in the OS specific format and rework it on loading? I think this demands a more serious discussion...

calixtus · 2020-05-28T18:59:38Z

Moreover, I just discovered that typing into the multi-line fields as "Abstract" and "Comment" (those with the problem) you have you have a lag for which if you type fast you cannot see what you are typing: a problem you do not have when directly typing within "{} biblatex source" where typing is a much smoother (normal) experience.

The reason for the lag could be the preview window. Could you please try to deactivate the Preview Window in Preferences->Preview, restart JabRef and try again?

gianlucabaldassarre · 2020-05-30T11:47:45Z

Yes, I confirm that typing is smooth if I "deactivate the Preview Window in Preferences->Preview", as you suggested. However, having the preview on the right of each field-tab is quite annoying (at least for me) for two reasons: 1) It takes a lot of space from the field windows (and why should I need to continuously see the preview?) 2) The preview flickers while you type anything, your corner-eye sees it, and this is highly annoying/distracting (indeed, peripheral vision has evolved to be strongly sensitive to changes! : ) An observation/suggestion that maybe might be used to solve both the problem of flickering and of the updating of the Preview Window creating a horrible lag on typing: you could change the program so that the content of the preview is updated only when you change field (or when you do a similar operation that means you have finished to update the field), rather than each time that you type something. Indeed, updating the previouw is computationally complicated and causes the problems above, and one does not actually need a preview that is always updated. I understand that the on-line update of the preview "looks cool", but if it impairs the key functionality of being able to type the fields smoothly (!), and it prevents the use of the handy "Preview Window" functionality, it is surely not worth it!

…

On Thu, 28 May 2020 at 20:59, Carl Christian Snethlage < ***@***.***> wrote: Moreover, I just discovered that typing into the multi-line fields as "Abstract" and "Comment" (those with the problem) you have you have a lag for which if you type fast you cannot see what you are typing: a problem you do not have when directly typing within "{} biblatex source" where typing is a much smoother (normal) experience. The reason for the lag could be the preview window. Could you please try to deactivate the Preview Window in Preferences->Preview, restart JabRef and try again? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6528 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADNLQD743E7744BIK5TA7WTRT2YCRANCNFSM4NKTOARQ> .

* upstream/master: (243 commits) fix checkstyle mEDRA DOI fetcher implementation. (#6641) Bump bcprov-jdk15on from 1.65.01 to 1.66 (#6676) Bump appleboy/ssh-action from v0.0.6 to v0.1.2 (#6674) Add localisation strings and renamed formatter Bump gittools/actions from v0.9.2 to v0.9.3 (#6675) Skip non-working sourcespy site Let dependabot update github actions Add three formatters to fix new lines in abstract and digits in editors Update src/test/java/org/jabref/logic/importer/fetcher/CollectionOfComputerScienceBibliographiesParserTest.java Fix to imports Make fetcher test more specific by checking each field explicitly Use builder instead of "setField" statements (docs) fix styling Update jpackage notes Fix automerge workflow fix markdown Bump org.beryx.jlink from 2.20.0 to 2.21.0 Bump unirest-java from 3.8.00 to 3.8.06 Fix to dependency on Global ...

…thout new lines

tobiasdiez · 2020-07-17T16:28:12Z

@Siedlerchr I think the build currently fails because of merging this PR (architecture violation)

Added check for different value

f21a540

calixtus added the entry-editor label May 26, 2020

tobiasdiez approved these changes May 27, 2020

View reviewed changes

Added trim to check

122b746

Siedlerchr marked this pull request as ready for review May 28, 2020 11:57

Fixed trim, added comment

8bcc65b

calixtus marked this pull request as draft June 5, 2020 14:00

Siedlerchr mentioned this pull request Jun 16, 2020

Cursors jumps to the beginning #5904

Closed

Prevent cursor jumping and maybe also library changed by comparing wi…

5be3cbe

…thout new lines

Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 12, 2020

Siedlerchr marked this pull request as ready for review July 14, 2020 09:22

Siedlerchr merged commit d5c42a5 into master Jul 17, 2020

Siedlerchr deleted the fix_6453 branch July 17, 2020 15:23

koppor mentioned this pull request Jul 27, 2020

Failing architecture tests #6697

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Additional check if values have changed in bindToEntry #6528

Additional check if values have changed in bindToEntry #6528

calixtus commented May 26, 2020 •

edited by Siedlerchr

Loading

calixtus commented May 27, 2020

Siedlerchr commented May 28, 2020

gianlucabaldassarre commented May 28, 2020 via email •

edited

Loading

calixtus commented May 28, 2020

calixtus commented May 28, 2020

tobiasdiez commented May 28, 2020

Siedlerchr commented May 28, 2020 •

edited

Loading

gianlucabaldassarre commented May 28, 2020 •

edited

Loading

calixtus commented May 28, 2020

calixtus commented May 28, 2020

Siedlerchr commented May 28, 2020

calixtus commented May 28, 2020

Siedlerchr commented May 28, 2020 •

edited

Loading

tobiasdiez commented May 28, 2020

Siedlerchr commented May 28, 2020 •

edited

Loading

tobiasdiez commented May 28, 2020

calixtus commented May 28, 2020

tobiasdiez commented May 28, 2020 •

edited

Loading

calixtus commented May 28, 2020

calixtus commented May 28, 2020 •

edited

Loading

gianlucabaldassarre commented May 30, 2020 via email

tobiasdiez commented Jul 17, 2020

Additional check if values have changed in bindToEntry #6528

Additional check if values have changed in bindToEntry #6528

Conversation

calixtus commented May 26, 2020 • edited by Siedlerchr Loading

calixtus commented May 27, 2020

Siedlerchr commented May 28, 2020

gianlucabaldassarre commented May 28, 2020 via email • edited Loading

calixtus commented May 28, 2020

calixtus commented May 28, 2020

tobiasdiez commented May 28, 2020

Siedlerchr commented May 28, 2020 • edited Loading

gianlucabaldassarre commented May 28, 2020 • edited Loading

calixtus commented May 28, 2020

calixtus commented May 28, 2020

Siedlerchr commented May 28, 2020

calixtus commented May 28, 2020

Siedlerchr commented May 28, 2020 • edited Loading

tobiasdiez commented May 28, 2020

Siedlerchr commented May 28, 2020 • edited Loading

tobiasdiez commented May 28, 2020

calixtus commented May 28, 2020

tobiasdiez commented May 28, 2020 • edited Loading

calixtus commented May 28, 2020

calixtus commented May 28, 2020 • edited Loading

gianlucabaldassarre commented May 30, 2020 via email

tobiasdiez commented Jul 17, 2020

calixtus commented May 26, 2020 •

edited by Siedlerchr

Loading

gianlucabaldassarre commented May 28, 2020 via email •

edited

Loading

Siedlerchr commented May 28, 2020 •

edited

Loading

gianlucabaldassarre commented May 28, 2020 •

edited

Loading

Siedlerchr commented May 28, 2020 •

edited

Loading

Siedlerchr commented May 28, 2020 •

edited

Loading

tobiasdiez commented May 28, 2020 •

edited

Loading

calixtus commented May 28, 2020 •

edited

Loading